WebXRController: Add grip update event if enabled.#33118
Merged
Mugen87 merged 6 commits intomrdoob:devfrom Mar 5, 2026
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Mar 4, 2026
Contributor
Author
|
It's done |
Clean up.
More clean up.
Fix comment.
Mugen87
approved these changes
Mar 4, 2026
Contributor
Author
|
Thanks for the refactored change. I have updated my gamepad feature on my side. https://github.com/danrossi/three-xr-controller-manager/blob/master/src/webxr/XRGamepad.js#L80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32353 #33118
Description
Adds a grip update event to the WebXRController to individually handle gamepad and input source for each controller. The event can be enabled / disabled easily so it's not being called all the time.
I found trying to handle gamepad inputs externally for each controller connected is clunky and should be handled in an event. I was forced to make a patched XRController to do this.
A gamepad helper can then use this event to handle gamepad inputs and dispatch specific events like in my patched XRController. Perhaps this can be added to the examples also.
https://github.com/danrossi/three-xr-controller/blob/main/src/XRController.js#L79