Skip to content

Reduce heap allocations in multi-pass scene rendering #9545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aardgoose wants to merge 7 commits into from
Closed

Reduce heap allocations in multi-pass scene rendering #9545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ceca2a0
use separate render lists for each scene to avoid array resize and
aardgoose Aug 18, 2016
c854a3b
avoid polluting scene objects, attach render lists to WebGLRenderer
aardgoose Aug 19, 2016
777788d
Merge pull request #1 from mrdoob/dev
aardgoose Aug 19, 2016
a72d47b
Merge pull request #4 from mrdoob/dev
aardgoose Aug 21, 2016
ab057e6
Merge pull request #5 from aardgoose/dev
aardgoose Aug 21, 2016
109f7ab
revised renderlist to use properties and don't sub class array - it d…
aardgoose Aug 21, 2016
19955a4
add dispose method the Object3D
aardgoose Aug 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/core/Object3D.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,12 @@ Object.assign( Object3D.prototype, EventDispatcher.prototype, {

return this;

},

dispose: function () {

this.dispatchEvent( { type: 'dispose' } );

}

} );
Expand Down
50 changes: 34 additions & 16 deletions src/renderers/WebGLRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,8 @@ function WebGLRenderer( parameters ) {

var lights = [];

var opaqueObjects = [];
var opaqueObjectsLastIndex = - 1;
var transparentObjects = [];
var transparentObjectsLastIndex = - 1;
var opaqueObjects = null;
var transparentObjects = null;

var morphInfluences = new Float32Array( 8 );

Expand Down Expand Up @@ -546,10 +544,8 @@ function WebGLRenderer( parameters ) {

this.dispose = function() {

transparentObjects = [];
transparentObjectsLastIndex = -1;
opaqueObjects = [];
opaqueObjectsLastIndex = -1;
opaqueObjects = null;
transparentObjects = null;

_canvas.removeEventListener( 'webglcontextlost', onContextLost, false );

Expand Down Expand Up @@ -603,6 +599,16 @@ function WebGLRenderer( parameters ) {

}

function onSceneDispose( event ) {

var scene = event.target;

scene.removeEventListener( 'dispose', onSceneDispose );

properties.delete( scene );

}

// Buffer rendering

this.renderBufferImmediate = function ( object, program, material ) {
Expand Down Expand Up @@ -1148,8 +1154,22 @@ function WebGLRenderer( parameters ) {

lights.length = 0;

opaqueObjectsLastIndex = - 1;
transparentObjectsLastIndex = - 1;
var sceneProperties = properties.get( scene );

if ( sceneProperties.opaqueRenderList === undefined ) {

sceneProperties.opaqueRenderList = [];
sceneProperties.transparentRenderList = [];

scene.addEventListener( 'dispose', onSceneDispose );

}

opaqueObjects = sceneProperties.opaqueRenderList;
transparentObjects = sceneProperties.transparentRenderList;

opaqueObjects.liveEntries = 0;
transparentObjects.liveEntries = 0;

sprites.length = 0;
lensFlares.length = 0;
Expand All @@ -1159,8 +1179,8 @@ function WebGLRenderer( parameters ) {

projectObject( scene, camera );

opaqueObjects.length = opaqueObjectsLastIndex + 1;
transparentObjects.length = transparentObjectsLastIndex + 1;
opaqueObjects.length = opaqueObjects.liveEntries;
transparentObjects.length = transparentObjects.liveEntries;

if ( _this.sortObjects === true ) {

Expand Down Expand Up @@ -1288,25 +1308,23 @@ function WebGLRenderer( parameters ) {

function pushRenderItem( object, geometry, material, z, group ) {

var array, index;
var array;

// allocate the next position in the appropriate array

if ( material.transparent ) {

array = transparentObjects;
index = ++ transparentObjectsLastIndex;

} else {

array = opaqueObjects;
index = ++ opaqueObjectsLastIndex;

}

// recycle existing render item or grow the array

var renderItem = array[ index ];
var renderItem = array[ array.liveEntries ++ ];

if ( renderItem !== undefined ) {

Expand Down