Update download_paths.json to be compatible with newer versions of Playwright#36
Draft
MatrixFrog wants to merge 1 commit intomrmeku:mainfrom
Draft
Update download_paths.json to be compatible with newer versions of Playwright#36MatrixFrog wants to merge 1 commit intomrmeku:mainfrom
MatrixFrog wants to merge 1 commit intomrmeku:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Currently still in progress but feel free to take a look to get the gist of it)
Several of these paths changed in Playwright in microsoft/playwright#38573 so rules_playwright without this change won't work with newer versions of Playwright, specifically 1.58.0 and up I believe.
On the other hand, with this change, it won't work with older versions of Playwright below 1.58.0, and could also be incompatible with future versions if Playwright changes their download paths again. So this is maybe not the ideal long-term fix but I don't know if Playwright provides a dependable public API for this information.