docs(SETUP.md): correct other JSI libs example#35
Open
david-gettins wants to merge 1 commit intomrousavy:masterfrom
Open
docs(SETUP.md): correct other JSI libs example#35david-gettins wants to merge 1 commit intomrousavy:masterfrom
david-gettins wants to merge 1 commit intomrousavy:masterfrom
Conversation
Owner
|
Hey! Thanks for the PR, but can you remove MMKV out of there? I think the MMKV docs explain how to set it up correctly anyways. |
Author
|
I've removed the MMKV part of the example and the RN 0.65 comment. As far as I am aware auto-linking JSI libs still hasn't made it in. |
david-gettins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MMKV into the example - I feel most people would be using these together and could use the example.Also, I had to follow this suggested fix but replace
mmkvwithmultithreading.