Skip to content

feat(ios): remove simulator camera restriction #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yocontra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ios): remove simulator camera restriction #3707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions package/ios/Core/CameraError.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ enum DeviceError {
case microphoneUnavailable
case lowLightBoostNotSupported
case focusNotSupported
case notAvailableOnSimulator
case pixelFormatNotSupported(targetFormats: [FourCharCode], availableFormats: [FourCharCode])

var code: String {
Expand All @@ -95,8 +94,6 @@ enum DeviceError {
return "low-light-boost-not-supported"
case .focusNotSupported:
return "focus-not-supported"
case .notAvailableOnSimulator:
return "camera-not-available-on-simulator"
case .pixelFormatNotSupported:
return "pixel-format-not-supported"
}
Expand All @@ -118,8 +115,6 @@ enum DeviceError {
return "The currently selected camera device does not support focusing!"
case .microphoneUnavailable:
return "The microphone was unavailable."
case .notAvailableOnSimulator:
return "The Camera is not available on the iOS Simulator!"
case let .pixelFormatNotSupported(targetFormats: targetFormats, availableFormats: availableFormats):
let tried = targetFormats.map { $0.toString() }
let found = availableFormats.map { $0.toString() }
Expand Down
5 changes: 0 additions & 5 deletions package/ios/Core/CameraSession+Configuration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ extension CameraSession {
}
videoDeviceInput = nil

#if targetEnvironment(simulator)
// iOS Simulators don't have Cameras
throw CameraError.device(.notAvailableOnSimulator)
#endif

guard let cameraId = configuration.cameraId else {
throw CameraError.device(.noDevice)
}
Expand Down