Open
Conversation
Tokens issued via the v3 OAuth2 flow need to be renewed via the v3 refresh endpoint. Also update the new login flow to return the refersh token required (i.e. from "step 3" rather than "step 4") to successfully issue new tokens.
Contributor
Author
|
Looks like we need an Apiary stub for https://owner-api.teslamotors.com. I'll look at adding this |
siribro12
approved these changes
Jun 6, 2021
Contributor
|
TeslaJS doesn't work at all for me without this patch! The existing refresh endpoint simply doesn't work with "v3" refresh tokens (which are the only ones you can get now). |
…mseminatore-master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tokens issued via the v3 OAuth2 flow need to be renewed via the v3 refresh endpoint.
Also update the new login flow to return the refresh token required (i.e. from "step 3" rather than "step 4") to successfully issue new tokens. The final JWT output has a refresh token too, but this seems not to be used and so is discarded.