Updated auth to use SSO tokens#280
Open
DoctorMcKay wants to merge 1 commit intomseminatore:masterfrom
Open
Conversation
|
Can this PR get merged ASAP? It seems that Tesla has deprecated the owner API authentication in favor of using auth.tesla.com which broke TeslaJS. This PR seems to fix it. |
Owner
|
Sorry for the delay. Other projects taking my time. I will have a look and see if I can safely merge it. |
|
I am just wondering if this will be merged at some point? |
|
Any update on this? Seems like a solid fix as the owner API does not work. Would love to see this merged ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner API now accepts JWTs issued by the SSO server, so it's no longer necessary to exchange the SSO JWT for an owner API-specific access token. This pull request removes that extra token exchange in the login function, and makes it possible to pass SSO refresh tokens to the
refreshTokenmethod (it's still possible to pass owner API refresh tokens; this is fully backwards-compatible).That said, updating the login function is purely academic as it seems that Tesla has added some browser-based security features to the login flow, including recaptcha. It seems that logging in using a non-browser app isn't going to be possible anymore. I've written a Chromium extension that lets you get tokens via the browser, however. It's been submitted to the Chrome and Edge stores and is awaiting review.