Replace deprecated msgpack-python with msgpack + python3 compatibility#23
Open
tbelhalfaoui wants to merge 1 commit intomsgpack-rpc:masterfrom
Open
Replace deprecated msgpack-python with msgpack + python3 compatibility#23tbelhalfaoui wants to merge 1 commit intomsgpack-rpc:masterfrom
tbelhalfaoui wants to merge 1 commit intomsgpack-rpc:masterfrom
Conversation
* Ensure Python 3 compatibility * Remove all encoding options (not needed with msgpack in Python 3)
tbelhalfaoui
force-pushed
the
fix-msgpack-dep
branch
from
c24d55d to
938a57e
Compare
|
@repeatedly Hello, could you review this PR and merge it? |
|
This project hasn't been updated in years; @tbelhalfaoui would you be able to publish your version as a new pypi module? The very old dependencies are an issue for me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @repeatedly!
I really like this lib, and I have found no equivalent of it: it is both very easy to use and very fast (the fastest Python lib I know of).
Sadly, there is one point that make it unusable for us: it depends on
msgpack-python, which is deprecated, and incompatible with the newmsgpack(which we use in the same code).So I tried #22 (only replacing the package name in requirements), but it does not work, because the
encodingparameter has been removed fromPackerandUnpackerinmsgpack==1.0.0(since it now uses UTF-8 by default).Hence this pull request, which ensures compatibility with
msgpack1.0.0 (tested only with python 3.6). I simply removed everything related to encodings.Thanks!