Skip to content

Comments

"ACCESS TO INSTANCES IN INITIALIZERS" deprecation#6

Open
parkan wants to merge 1 commit intomszoernyi:masterfrom
parkan:deprecationfix
Open

"ACCESS TO INSTANCES IN INITIALIZERS" deprecation#6
parkan wants to merge 1 commit intomszoernyi:masterfrom
parkan:deprecationfix

Conversation

@parkan
Copy link

@parkan parkan commented Sep 1, 2015

@parkan
Copy link
Author

parkan commented Sep 1, 2015

Hmm actually this will still not load the mixpanel js correctly. Maybe need to upstream some changes from https://github.com/sportly/ember-cli-mixpanel-service (which works for me under ember 2.0.1/ember-cli 1.13.8)

@zkwentz
Copy link

zkwentz commented Nov 30, 2015

@parkan can you detail what you've done?

@parkan
Copy link
Author

parkan commented Dec 1, 2015

@zkwentz sorry, it's been a while. From what I remember I moved the container-dependent code to the instance initializer, because the initializer call signature has changed from initialize: function(container, application) to initialize: function(registry, application) (so the container is now only present in the instanceInitializer call)

This allows the addon to boot, but the external mixpanel dependency still wasn't loading for me after the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants