"ACCESS TO INSTANCES IN INITIALIZERS" deprecation#6
Open
parkan wants to merge 1 commit intomszoernyi:masterfrom
Open
"ACCESS TO INSTANCES IN INITIALIZERS" deprecation#6parkan wants to merge 1 commit intomszoernyi:masterfrom
parkan wants to merge 1 commit intomszoernyi:masterfrom
Conversation
Author
|
Hmm actually this will still not load the mixpanel js correctly. Maybe need to upstream some changes from https://github.com/sportly/ember-cli-mixpanel-service (which works for me under ember 2.0.1/ember-cli 1.13.8) |
|
@parkan can you detail what you've done? |
Author
|
@zkwentz sorry, it's been a while. From what I remember I moved the container-dependent code to the instance initializer, because the initializer call signature has changed from This allows the addon to boot, but the external mixpanel dependency still wasn't loading for me after the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will now work with 2.0.0