Verify handling of Japanese characters #589
Merged
+45
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a unit test to verify that Japanese characters are properly handled and preserved when passed through the MTConnect agent in both XML and JSON response formats.
Changes:
- Added new test case
should_handle_japanese_charactersthat validates Japanese character handling in both XML and JSON formats - Added
PARSE_JSON_RESPONSE_QUERYmacro to complement the existing XML equivalent for consistency - Minor formatting improvement to an existing test assertion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test_package/agent_test.cpp | Added comprehensive test case for Japanese character handling in XML and JSON responses; enabled JSON version 2 in test setup |
| test_package/agent_test_helper.hpp | Added PARSE_JSON_RESPONSE_QUERY macro for future JSON response testing with query parameters |
| test_package/websockets_rest_sink_test.cpp | Reformatted multi-line assertion for better readability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
simonyg
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit test to check if Japanese characters will pass through the agent unchanged in XML and JSON