Skip to content

Enable focusing on zelect by tabbing #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antris wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable focusing on zelect by tabbing #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions tabtest.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Tabbing test</title>
<script src="node_modules/jquery-browser/lib/jquery.js"></script>
<script src="zelect.js"></script>
</head>
<body>
<h2>With <code>tabindex</code></h2>
<p><input type="text" class="field1" tabindex="1" /></p>
<p><select class="field2" tabindex="2">
<option>First</option>
<option>Last</option>
</select></p>
<p><input type="text" class="field3" tabindex="3" /></p>
<h2>Without <code>tabindex</code></h2>
<p><input type="text" class="field1" /></p>
<p><select class="field2">
<option>First</option>
<option>Last</option>
</select></p>
<p><input type="text" class="field3" /></p>
<script>
$('select').zelect()
</script>
</body>
</html>
8 changes: 8 additions & 0 deletions test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@
<option value="something-elese">Also has a value</option>
<option value="">Has empty string as value</option>
</select>
<div class="multiple-fields">
<p><input type="text" class="field1" /></p>
<p><select class="field2">
<option>First</option>
<option>Last</option>
</select></p>
<p><input type="text" class="field3" /></p>
</div>
</div>
</body>
</html>
11 changes: 11 additions & 0 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,17 @@ describe('zelect', function() {
})
})

describe('Catching tab focus', function() {
beforeEach(function() {
setup('multiple-fields')
$('#select').find('.field2').zelect()
})
it('focusing on catcher element opens search', function() {
$('#select').find('.focuz').focus()
defaultOpenState()
})
})

function ok(bool, msg) {
assert.isTrue(bool, msg)
}
Expand Down
10 changes: 8 additions & 2 deletions zelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
var $zelect = $('<div>').addClass('zelect')
var $selected = $('<div>').addClass('zelected')
var $dropdown = $('<div>').addClass('dropdown').hide()
var $focusCatcher = $('<input>').addClass('focuz').css({ height: 0, width: 0, border: 'none', display: 'block', padding: 0 })
var $noResults = $('<div>').addClass('no-results')
var $search = $('<input>').addClass('zearch')
var $list = $('<ol>')
Expand Down Expand Up @@ -60,7 +61,7 @@
})
$search.keydown(function(e) {
switch (e.which) {
case keys.tab: e.preventDefault(); hide(); return;
case keys.tab: hide(); return;
case keys.up: e.preventDefault(); listNavigator.prev(); return;
case keys.down: e.preventDefault(); listNavigator.next(); return;
}
Expand All @@ -69,12 +70,15 @@
$list.on('click', 'li', function() { selectItem($(this).data('zelect-item')) })
$zelect.mouseenter(function() { $zelect.addClass('hover') })
$zelect.mouseleave(function() { $zelect.removeClass('hover') })
$zelect.attr("tabindex", $select.attr("tabindex"))
$search.attr("tabindex", $select.attr("tabindex"))
$focusCatcher.attr("tabindex", $select.attr("tabindex"))
$zelect.blur(function() { if (!$zelect.hasClass('hover')) hide() })
$search.blur(function() { if (!$zelect.hasClass('hover')) hide() })

$selected.click(toggle)
$focusCatcher.focus(toggle)

$focusCatcher.insertBefore($select)
$zelect.insertAfter($select)
.append($selected)
.append($dropdown.append($('<div>').addClass('zearch-container').append($search).append($noResults)).append($list))
Expand Down Expand Up @@ -115,6 +119,7 @@

function toggle() {
$dropdown.toggle()
$focusCatcher.hide()
$zelect.toggleClass('open')
if ($dropdown.is(':visible')) {
$search.focus().select()
Expand All @@ -126,6 +131,7 @@
function hide() {
$dropdown.hide()
$zelect.removeClass('open')
setTimeout(function(){ $focusCatcher.show() }, 0)
}

function renderContent($obj, content) {
Expand Down