AGP 9.0 > fix compat with android.r8.optimizedResourceShrinking

[mmathieum]

After:

• AGP 9.0 > fix compat with android.r8.optimizedResourceShrinking commons-android#58

Following:

• APG 9.0.0 migration #523

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a compatibility issue with Android Gradle Plugin (AGP) 9.0 by adjusting build configuration settings. The changes ensure that resource shrinking and code minification are correctly enabled for release builds, which is crucial for optimizing application size and performance when using newer AGP versions.

Highlights

• AGP 9.0 Compatibility Fix: Modified the release build type configuration in shared/app-android/build.gradle to set shrinkResources and minifyEnabled to true, addressing compatibility issues with Android Gradle Plugin 9.0 and the android.r8.optimizedResourceShrinking flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables code and resource shrinking for release builds of non-main app modules by setting minifyEnabled and shrinkResources to true. This is a good practice for optimizing app size. The change is likely to address compatibility with AGP 9.0 as indicated by the title. I have one suggestion to make this change more robust and prevent potential runtime issues.