Add "last trip stop"

[mmathieum]

• Add "last trip stop" commons-java#23

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on minor code cleanup and refactoring to enhance the readability and maintainability of the GTFS parsing logic. Changes include renaming a method for better type indication, simplifying loop structures, and applying final modifiers to improve code clarity. Additionally, it incorporates small documentation improvements and corrects a typo in existing comments.

Highlights

• Code Readability & Maintainability: Improved code clarity by renaming a method in GSpec.java from getFrequencyTripIds() to getFrequencyTripIdInts() to better reflect its return type, and by adding final modifiers to several local variables for immutability.
• Refactoring: Refactored the generateTripStops() method in GSpec.java by removing an unused variable and converting an indexed for-loop to an enhanced for-loop for cleaner iteration.
• Documentation & Comments: Enhanced code documentation in GStopTime.kt by adding comments to clarify the format of arrival and departure time properties, and corrected a minor typo in comments within MSchedule.kt.
• Annotation Cleanup: Removed an unnecessary @Suppress("unused") annotation from a constructor in GTripStop.kt.

Changelog

• src/main/java/org/mtransit/parser/gtfs/data/GSpec.java
  • Renamed getFrequencyTripIds() to getFrequencyTripIdInts().
  • Removed unused gStopTime variable.
  • Replaced indexed for-loop with enhanced for-loop for GStopTime iteration.
  • Applied final modifier to tripStopTimes, newGStopTimes, stopTimeCal, gStopTimeIncInSec, newGeneratedTripIdInt, newDepartureTime, pickupType, dropOffType, timePoint, and newGStopTime variables.
• src/main/java/org/mtransit/parser/gtfs/data/GStopTime.kt
  • Added // HHmmss comments to _arrivalTime and _departureTime properties for clarity.
• src/main/java/org/mtransit/parser/gtfs/data/GTripStop.kt
  • Removed @Suppress("unused") annotation from a constructor.
• src/main/java/org/mtransit/parser/mt/data/MSchedule.kt
  • Added // MStopTime comment next to the MSchedule class declaration.
  • Corrected "an minute" to "a minute" in comments.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a series of refactorings that enhance code quality and readability. The changes primarily consist of stylistic improvements such as renaming a method for better clarity, converting traditional for-loops to enhanced for-loops, and adding the final keyword to local variables to favor immutability. I have included one suggestion to refactor a mutable variable (var) into an immutable one (val) in a Kotlin file, which aligns with best practices for writing safer and more predictable code.

[mmathieum]

/gemini review