chore(shell): remove interactive command check and warning#24
Merged
mudler merged 1 commit intomudler:masterfrom Mar 4, 2026
Merged
chore(shell): remove interactive command check and warning#24mudler merged 1 commit intomudler:masterfrom
mudler merged 1 commit intomudler:masterfrom
Conversation
This removes the isInteractiveCommand function and related warning messages while preserving the important process group management and timeout handling that prevents commands from stalling indefinitely. The process group kill on timeout and environment variables for non-interactive mode are retained as they are critical for proper cleanup.
mudler
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the interactive command check and warning from the shell MCP implementation as requested in the task.
Changes
Rationale
The process group management and timeout handling are critical for preventing commands from stalling indefinitely. These features remain intact while simplifying the shell behavior by removing the interactive command detection logic.
Testing