Add support for stream deck pedal without visuals#18
Open
moenzuel wants to merge 1 commit intomuesli:masterfrom
Open
Add support for stream deck pedal without visuals#18moenzuel wants to merge 1 commit intomuesli:masterfrom
moenzuel wants to merge 1 commit intomuesli:masterfrom
Conversation
Owner
|
Thanks for the PR, @moenzuel! The change looks sound, I just haven't had a chance to try it out with actual hardware (delivery got delayed by several weeks). |
f4cb9a0 to
cc7ae24
Compare
Author
|
Gave this an update on the chance this can still merge |
Owner
Author
|
@muesli Yes, it acts the same as a standard stream deck but with only 3 buttons and no displays. |
|
Yeah, code does seem good - I just wonder how deckmaster is geared to handle mutliple devices, or would I just run two instances with a flag, @muesli? |
|
ahhh from deckmaster docs; nice! I will set up and report back later today, thank you |
Owner
|
Correct, I'd suggest using a separate instance per device, using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting the pedal seems straight forward enough. It doesn't have visuals so block out most of the commands. Adding just this allows basic support in the downstream deckmaster. I'm not sure on the featureReportSize but 32 seemed to be enough.
n.b. I don't normally write Go code so I may have done something terrible too.