Open
Conversation
Implements interactive column sorting for query results (#34): - Press 's' to cycle: unsorted → ascending → descending → unsorted - Sort indicators (▲/▼) displayed in column headers - Supports numeric, text, boolean, date/time comparison with NULLs last - Cross-type numeric comparison (Int16/Int32/Int64/Float32/Float64) - Sort state resets when switching result sets or executing new queries Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skeyChanges
src/db/query.rs: Addedsort_cmp()method onCellValuewith comprehensive type-aware comparison logic and 7 unit testssrc/ui/app.rs: Addedtoggle_column_sort(),clear_sort(),rebuild_sort_indices(), andsorted_row_index()methods; added sort state fields; wiredskey handlersrc/ui/components.rs: Updateddraw_result_table()to display sort indicators (▲/▼) in headers and render rows using sorted indices; addedsshortcut to help overlayTest plan
cargo buildcompiles without warningssto sort ascending, press again for descending, press again to clearCloses #34
🤖 Generated with Claude Code