Open
Conversation
Implements Ctrl+F (Find) and Ctrl+H (Find & Replace) in the editor (#35): - Inline find bar with live search as you type - Case-sensitive toggle with Ctrl+C in find mode - Match highlighting: current match in yellow, other matches in blue - Navigate matches with Enter/Shift+Enter or Up/Down arrows - Replace current match (Enter in replace field) - Replace all occurrences (Ctrl+Shift+Enter) - Pre-fills search with selected text when opening - Tab to switch between search and replace fields - Esc to close find bar - 15 unit tests covering search, navigation, and replacement Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Resolve merge conflicts in app.rs and components.rs keeping both find/replace feature and autocomplete additions from main - Fix clippy::if_same_then_else in update_find_matches by combining conditions - Run cargo fmt for consistent formatting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+Fto open a find bar andCtrl+Hto open find & replace in the query editorEnter/Shift+EnterorUp/DownarrowsEnterin replace field, replace all withCtrl+Shift+EnterCtrl+Cwhile in find modeChanges
src/ui/app.rs: AddedFindReplaceStatestruct andFindReplaceFieldenum, find/replace state toApp, input handler for find/replace mode, search/navigation/replace methods, 15 unit testssrc/ui/components.rs: Addeddraw_find_bar()function, updateddraw_editor()to render find bar above editor content, added match highlighting to syntax highlighter, added shortcuts to help overlayTest plan
cargo buildcompiles without warningsCtrl+Fin editor, type search text, verify matches highlightEnterto cycle through matches,Shift+Enterfor reverseCtrl+H, type replacement, pressEnterto replace one occurrenceCtrl+Shift+Enterto replace all occurrencesCtrl+F, verify search pre-filledEscto close find barCloses #35
🤖 Generated with Claude Code