Fix UI layout: dynamic editor/results split and scrollable help#63
Open
Fix UI layout: dynamic editor/results split and scrollable help#63
Conversation
- Autocomplete popup now uses the dynamic editor_height_percent instead of a hardcoded 40% for positioning, so it tracks the actual editor pane when resized with Ctrl+Shift+Up/Down - Help overlay adapts to small terminals by using available height and supports scrolling with Up/Down/PageUp/PageDown - Added scroll hint to help overlay footer Closes #61 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
editor_height_percentinstead of a hardcodedPercentage(40), so the popup correctly tracks the editor pane when resized with Ctrl+Shift+Up/DownWhat Changed
src/ui/app.rs: Addedhelp_scrollfield toAppstruct; added scroll handling (Up/Down/PageUp/PageDown) tohandle_help_input()src/ui/components.rs: FixedConstraint::Percentage(40)→Constraint::Percentage(app.editor_height_percent)for autocomplete positioning; rewrotedraw_help_overlay()to support scrolling and dynamic heightTest Plan
?) in a small terminal (e.g., 40 rows) — should show as much content as fits, with scroll hint at bottom?to close help — scroll position resetscargo test— all 230 tests passCloses #61
🤖 Generated with Claude Code