Conversation
90288d8 to
379d881
Compare
These really don't belong in the root package.
379d881 to
4449d49
Compare
raulk
left a comment
There was a problem hiding this comment.
A package containing a single component introduces complexity for no reason. In idiomatic Go, filters.Filter is also a smell that the package shouldn’t exist.
|
I agree that single-type packages are suboptimal, but it doesn't belong in the root package. A multiaddr set might belong in the root package, but this filter type is highly specialized (special IPNet functions, filter actions, etc.). Remember, this package has implementations in many languages and needs to present a cohesive minimal interface. How about a compromise:
|
|
@Stebalien Deal taken! That simplifies our codebase even further. Is this something you plan on tackling? |
|
Yeah. It's been annoying me for a while... I wonder if I can fold go-multiaddr-dns into the deal. |
|
@Stebalien Nowwwww we're talking :-) |
|
Replaced with #127. |
These really don't belong in the root package.