Test legacy relayed V1 & V2 before and after de-activation. Removed some dead code, as well.#138
Merged
andreibancioiu merged 9 commits intomainfrom Sep 15, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 61.65% 61.68% +0.03%
==========================================
Files 48 48
Lines 3792 3769 -23
==========================================
- Hits 2338 2325 -13
+ Misses 1302 1292 -10
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes dead code and tests for legacy relayed V1 & V2 transactions both before and after their de-activation. The primary purpose is to clean up deprecated functionality while adding test coverage for the deactivation behavior of relayed transaction versions V1 and V2.
- Adds a new
run-for-relayed-v1-v2command to test legacy relayed transactions before and after deactivation - Removes deprecated activation epoch tracking and related dead code
- Updates version to v0.8.0 and infrastructure configuration for testing
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version/constants.go | Updates middleware version to v0.8.0 |
| testscommon/networkProviderMock.go | Removes deprecated activation epoch fields and related methods |
| systemtests/localnet.toml | Updates configuration for testing with longer epoch duration and newer software versions |
| systemtests/generate_testdata_on_network.py | Adds new command to test legacy relayed V1/V2 transactions and refactors existing transaction generation |
| systemtests/config.py | Replaces activation epoch fields with custom tokens completion and deactivation epochs |
| systemtests/check_with_mesh_cli.py | Removes deprecated activation epoch command line parameter |
| server/services/*_test.go | Removes deprecated activation epoch mock setup |
| server/services/transactionsFeaturesDetector.go | Removes unused method for detecting legacy relayed V1 transactions |
| server/services/interface.go | Removes deprecated IsReleaseSpicaActive method |
| server/provider/networkProvider.go | Removes Spica activation epoch tracking and related functionality |
| server/factory/*.go | Removes activation epoch parameters from factory interfaces |
| requirements-dev.txt | Updates SDK version and adds deprecation note |
| cmd/rosetta/*.go | Removes activation epoch CLI flag and related functionality |
| README.md | Adds documentation for new test command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
andreibancioiu
commented
Sep 11, 2025
| return withSendingValueToNonPayableContract || withMetaTransactionIsInvalid | ||
| } | ||
|
|
||
| func (detector *transactionsFeaturesDetector) isRelayedV1TransactionCompletelyIntrashardWithSignalError(tx *transaction.ApiTransactionResult, innerTx *innerTransactionOfRelayedV1) bool { |
andreibancioiu
commented
Sep 11, 2025
| gas_limit=5_000_000, | ||
| relayer=accounts.get_user(shard=SOME_SHARD, index=0), | ||
| ), await_processing_started=True) | ||
| if configuration.generate_relayed_v3: |
Collaborator
Author
There was a problem hiding this comment.
Only added if configuration.generate_relayed_v3:. Here and below.
sstanculeanu
approved these changes
Sep 11, 2025
miiu96
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No actual change in production code - not necessary for the de-activation of legacy relayed transactions (V1 and V2).