Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the MultisigWrapper class that acted as an intermediary layer around the MultisigTransactionsFactory from the SDK. The wrapper is replaced with direct usage of the MultisigController from the SDK, simplifying the architecture and eliminating code duplication.
- Removed the entire
multisig.pyfile containing theMultisigWrapperclass - Updated
cli_multisig.pyto useMultisigControllerdirectly instead of the wrapper - Renamed a function in
cli_shared.pyfrom_get_address_hrptoget_address_hrp_with_fallbackand made it public
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| multiversx_sdk_cli/multisig.py | Complete removal of the MultisigWrapper class and its methods |
| multiversx_sdk_cli/cli_multisig.py | Refactored to use MultisigController directly, updated method calls and parameter handling |
| multiversx_sdk_cli/cli_shared.py | Renamed function and made it public for broader usage |
| multiversx_sdk_cli/cli_governance.py | Updated to use the renamed function and fixed getattr usage |
| multiversx_sdk_cli/cli_get.py | Updated function calls to match new naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| address = Address.new_from_bech32(args.address) | ||
| else: | ||
| hrp = cli_shared._get_address_hrp(args) | ||
| hrp = cli_shared.get_address_hrp(args) |
There was a problem hiding this comment.
The function call should be get_address_hrp_with_fallback(args) to match the renamed function in cli_shared.py.
| address = Address.new_from_bech32(args.address) | ||
| else: | ||
| hrp = cli_shared._get_address_hrp(args) | ||
| hrp = cli_shared.get_address_hrp(args) |
There was a problem hiding this comment.
The function call should be get_address_hrp_with_fallback(args) to match the renamed function in cli_shared.py.
| address = Address.new_from_bech32(args.address) | ||
| else: | ||
| hrp = cli_shared._get_address_hrp(args) | ||
| hrp = cli_shared.get_address_hrp(args) |
There was a problem hiding this comment.
The function call should be get_address_hrp_with_fallback(args) to match the renamed function in cli_shared.py.
| address = Address.new_from_bech32(args.address) | ||
| else: | ||
| hrp = cli_shared._get_address_hrp(args) | ||
| hrp = cli_shared.get_address_hrp(args) |
There was a problem hiding this comment.
The function call should be get_address_hrp_with_fallback(args) to match the renamed function in cli_shared.py.
3 participants
No description provided.