-
-
Notifications
You must be signed in to change notification settings - Fork 82
build: upgrade to rust v1.86.0 #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wodann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the upgrade. A couple of questions about your proposed fixes
366af44 to
4c13594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the codebase to remove the obsolete Upcast trait usage and the mun_db dependency in favor of direct database references, in line with the Rust 1.86.0 bump. Key changes include:
- Replacing calls to db.upcast() with passing db directly.
- Removing the mun_db crate (and its Cargo.toml entries and implementations) from the project.
- Updating a size calculation to use the new .div_ceil() method.
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/mun_hir/src/code_model/function.rs | Replaced all db.upcast() calls with direct db usage. |
| crates/mun_hir/src/code_model.rs | Updated struct data retrieval to use db directly. |
| crates/mun_hir/Cargo.toml | Removed the mun_db dependency. |
| crates/mun_db/src/lib.rs & Cargo.toml | Entirely removed mun_db and its Upcast trait implementation. |
| crates/mun_compiler/src/driver.rs & db.rs | Removed db.upcast() calls and Upcast implementations. |
| crates/mun_compiler/Cargo.toml | Removed dependency on mun_db. |
| crates/mun_codegen/* | Updated all relevant modules to stop using db.upcast() and to use db directly. |
| crates/mun_abi/src/type_info.rs | Updated size calculation using .div_ceil(). |
Comments suppressed due to low confidence (1)
crates/mun_abi/src/type_info.rs:111
- Typo in error message: 'covert' should be corrected to 'convert'.
.expect("cannot covert size in bytes to platform size")
Wodann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes! 🙏
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
+ Coverage 87.62% 87.88% +0.25%
==========================================
Files 275 275
Lines 32228 32193 -35
==========================================
+ Hits 28239 28292 +53
+ Misses 3989 3901 -88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.