Skip to content

Conversation

@gvozdvmozgu
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the upgrade. A couple of questions about your proposed fixes

@gvozdvmozgu gvozdvmozgu force-pushed the chore/bump/rust-1.86.0 branch from 366af44 to 4c13594 Compare April 27, 2025 19:43
@Wodann Wodann requested a review from Copilot April 28, 2025 00:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to remove the obsolete Upcast trait usage and the mun_db dependency in favor of direct database references, in line with the Rust 1.86.0 bump. Key changes include:

  • Replacing calls to db.upcast() with passing db directly.
  • Removing the mun_db crate (and its Cargo.toml entries and implementations) from the project.
  • Updating a size calculation to use the new .div_ceil() method.

Reviewed Changes

Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/mun_hir/src/code_model/function.rs Replaced all db.upcast() calls with direct db usage.
crates/mun_hir/src/code_model.rs Updated struct data retrieval to use db directly.
crates/mun_hir/Cargo.toml Removed the mun_db dependency.
crates/mun_db/src/lib.rs & Cargo.toml Entirely removed mun_db and its Upcast trait implementation.
crates/mun_compiler/src/driver.rs & db.rs Removed db.upcast() calls and Upcast implementations.
crates/mun_compiler/Cargo.toml Removed dependency on mun_db.
crates/mun_codegen/* Updated all relevant modules to stop using db.upcast() and to use db directly.
crates/mun_abi/src/type_info.rs Updated size calculation using .div_ceil().
Comments suppressed due to low confidence (1)

crates/mun_abi/src/type_info.rs:111

  • Typo in error message: 'covert' should be corrected to 'convert'.
.expect("cannot covert size in bytes to platform size")

Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes! 🙏

@Wodann Wodann changed the title chore: bump rust 1.86.0 build: upgrade to rust v1.86.0 Apr 28, 2025
@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.88%. Comparing base (d43f596) to head (4c13594).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/mun_hir/src/code_model/impl.rs 0.00% 2 Missing ⚠️
crates/mun_hir/src/semantics.rs 33.33% 2 Missing ⚠️
crates/mun_hir/src/code_model.rs 0.00% 1 Missing ⚠️
crates/mun_hir/src/code_model/function.rs 83.33% 1 Missing ⚠️
crates/mun_hir/src/code_model/type_alias.rs 90.00% 1 Missing ⚠️
crates/mun_hir/src/method_resolution.rs 85.71% 1 Missing ⚠️
crates/mun_hir/src/package_defs/collector.rs 95.45% 1 Missing ⚠️
crates/mun_syntax/src/ast/tokens.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   87.62%   87.88%   +0.25%     
==========================================
  Files         275      275              
  Lines       32228    32193      -35     
==========================================
+ Hits        28239    28292      +53     
+ Misses       3989     3901      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Wodann Wodann merged commit 90e88f3 into mun-lang:main Apr 28, 2025
18 checks passed
@gvozdvmozgu gvozdvmozgu deleted the chore/bump/rust-1.86.0 branch April 28, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants