This repository was archived by the owner on Jan 6, 2026. It is now read-only.
Merge main into sdl_input #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR merges main branch changes into the sdl_input branch, which includes bug fixes to correct joystick Y-axis range handling and cleanup of plugin name macros.
- Fixed incorrect Y-axis range from [-127, 128] to correct [-128, 127] to match signed 8-bit integer constraints
- Added explicit int8_t casts when assigning joystick positions to ensure proper type conversion
- Simplified plugin name macros by removing architecture and target strings in non-x64/non-debug builds
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/TASInput.cpp | Adds int8_t casts for joystick position assignment and corrects Y-axis wrapping_clamp range |
| src/Main.h | Simplifies PLUGIN_ARCH and PLUGIN_TARGET macros to empty strings for non-x64/release builds |
| src/JoystickControl.cpp | Corrects Y-axis range in remap functions to match [-128, 127] constraint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ctx->current_input.x = (int8_t)x; | ||
| ctx->current_input.y = (int8_t)y; | ||
There was a problem hiding this comment.
Line 591 contains trailing whitespace. Remove the trailing whitespace to maintain code cleanliness.
Suggested change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.