release: v0.20260313.0 - SQLite Memory & SIF Reliability#126
Merged
ranaroussi merged 13 commits intorcfrom Mar 13, 2026
Merged
Conversation
The overlord config loading path defaulted auto_decomposition to True, overriding the constructor default of False. This caused simple messages to trigger workflow planning even when the formation didn't configure it. Now defaults to enable_workflow_by_default (False) unless the formation explicitly sets overlord.workflow.auto_decomposition: true. Also: surface persistent memory init failures in startup output instead of silently swallowing them.
The sqlite-vec 0.1.6 PyPI package ships a 32-bit ARM binary in the aarch64 wheel (known bug: asg017/sqlite-vec#211). This causes 'wrong ELF class: ELFCLASS32' at runtime, silently breaking persistent memory in SIF containers on ARM64. Fix: download the sqlite-vec amalgamation source and compile a correct 64-bit vec0.so during the Docker build (aarch64 only).
…ser_id) In single-user mode, persistent_memory_manager passes user_id=None to SQLiteMemory.search(). The search method tried to fall back to self.default_user_id which doesn't exist, causing an AttributeError that was silently caught. Memories were stored but never retrieved. Fix: when user_id is None, search without user filtering (appropriate for single-user mode). Removed the nonexistent default_user_id references from both search() and _search_internal().
SQLiteMemory uses all-MiniLM-L6-v2 for local embeddings but it was not pre-downloaded in the Docker build. In read-only SIF containers, HuggingFace Hub failed with 'Read-only file system' when trying to download or cache the model at runtime. - Pre-download both embedding models at build time - Set HF_HUB_OFFLINE=1 and TRANSFORMERS_OFFLINE=1 to prevent cache writes - Bump version to 0.20260312.1
…conditional HF offline - Add SHA-256 checksum verification for sqlite-vec amalgamation download - Derive Python version dynamically instead of hardcoding python3.10 - Move HF_HUB_OFFLINE/TRANSFORMERS_OFFLINE from Dockerfile ENV to entrypoint, gated on SINGULARITY_CONTAINER or MUXI_SIF_MODE
Greptile SummaryThis PR ships five targeted bug fixes for SQLite memory retrieval failures and SIF container reliability issues, incorporating the follow-up improvements requested during review of PR #125. Key changes:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["_search_internal(query_embedding, k, collection, user_id)"] --> B{collection AND user_id?}
B -->|Yes| C["SQL: WHERE m.collection = ?\n AND m.user_id = ?\n AND u.formation_id = ?"]
B -->|No| D{collection only?}
D -->|Yes| E["SQL: WHERE m.collection = ?\n AND u.formation_id = ?\n(all users in formation)"]
D -->|No| F{user_id only?}
F -->|Yes| G["SQL: WHERE m.user_id = ?\n AND u.formation_id = ?"]
F -->|No| H["SQL: WHERE u.formation_id = ?\n(all users, all collections)"]
C --> I[Execute & return scored results]
E --> I
G --> I
H --> I
Last reviewed commit: e682c14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five bug fixes addressing SQLite memory retrieval and SIF container reliability.
Bug Fixes
search()and_search_internal()referenced a nonexistentdefault_user_idattribute. Memories stored correctly but never retrieved. Fix: 4-way SQL branching whenuser_id=None.all-MiniLM-L6-v2was not pre-downloaded during Docker build. Fix: pre-download both models..no_existcache files to read-only filesystem. Fix:HF_HUB_OFFLINE=1+TRANSFORMERS_OFFLINE=1(conditional, SIF-only via entrypoint).auto_decompositiondefault override — HardcodedTrueoverriding constructorFalse. Fix: defaults toenable_workflow_by_default.Review Fixes (from PR #125)
python3.10SINGULARITY_CONTAINERChanges