Fix for the dot problem in the class name#2
Open
aleksandar-manukov wants to merge 1 commit intomvdcorput:masterfrom
Open
Fix for the dot problem in the class name#2aleksandar-manukov wants to merge 1 commit intomvdcorput:masterfrom
aleksandar-manukov wants to merge 1 commit intomvdcorput:masterfrom
Conversation
If you have a resx file named for example Translations.nl.resx, the module will generate a ts file with a class named Translations.nl which is not a correct class name. With this change the class name will be Translations_nl which is a correct class name and you can continue using the generated ts files as you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a resx file named for example Translations.nl.resx, the module will generate a ts file with a class named Translations.nl which is not a correct class name. With this change the class name will be Translations_nl which is a correct class name and you can continue using the generated ts files as you want.