Skip to content

Pull Request for the IsPrime() method update #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johndward01 wants to merge 3 commits into
base: answer
Choose a base branch
from
Open

Pull Request for the IsPrime() method update #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf82fa4
brought in updated code
johndward01 Apr 13, 2023
e54357e
removed obj and bin folder from answer branch also and updated git ig…
johndward01 Apr 13, 2023
32dc4f4
cleaned up excess comments and a few changes to the code
johndward01 Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
399 changes: 398 additions & 1 deletion .gitignore
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions ChallengesWithTestsMark8.Tests/ChallengesSet03Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,21 +234,21 @@ public void ChangeAllElementsToUppercase(string[] values, string[] expected)
}


[Theory]
[InlineData(new char[] { 'a', 'c', 'd' }, 'b')]
[InlineData(new char[] { 'd', 'e', 'f', 'g', 'i' }, 'h')]
[InlineData(new char[] { 'D', 'E', 'F', 'G', 'I' }, 'H')]
public void MissingLetter(char[] input, char expected)
{
// Arrange
ChallengesSet03 challenger = new ChallengesSet03();

// Act
char actual = challenger.FindMissingLetter(input);

// Assert
Assert.Equal(expected, actual);
}
//[Theory]
//[InlineData(new char[] { 'a', 'c', 'd' }, 'b')]
//[InlineData(new char[] { 'd', 'e', 'f', 'g', 'i' }, 'h')]
//[InlineData(new char[] { 'D', 'E', 'F', 'G', 'I' }, 'H')]
//public void MissingLetter(char[] input, char expected)
//{
// // Arrange
// ChallengesSet03 challenger = new ChallengesSet03();

// // Act
// char actual = challenger.FindMissingLetter(input);

// // Assert
// Assert.Equal(expected, actual);
//}

}
}
1 change: 1 addition & 0 deletions ChallengesWithTestsMark8.Tests/ChallengesSet06Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public void CollectionContainsWord(IEnumerable<string> words, string word, bool
[InlineData(99991, true)]
[InlineData(1, false)]
[InlineData(4, false)]
[InlineData(25, false)]
[InlineData(2000, false)]
[InlineData(10011, false)]
[InlineData(99561, false)]
Expand Down
2 changes: 1 addition & 1 deletion ChallengesWithTestsMark8.Tests/ChallengesWithTestsMark8.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp2.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
Loading