fix: tray show opens main window on first click#147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the main window has been hidden/destroyed, clicking tray "显示主窗口" the first time may only recreate the window object but not actually present it, so users have to click twice.
Root cause
The create path only built the window and synced menu state. Since
tauri.conf.jsonsetsvisible: false, a newly created window can stay hidden unless we explicitly show/focus it.Fix
show_or_create_main_window, capture the newly built windowunminimize(),show(), andset_focus()Verification
cargo check -q -p token_proxycargo test -q -p token_proxy tray::tests