This repository was archived by the owner on Nov 10, 2017. It is now read-only.
Improve diagnostics (PhantomJS logs, Readability.js messages/errors)#21
Open
nickolay wants to merge 6 commits inton1k0:masterfrom
Open
Improve diagnostics (PhantomJS logs, Readability.js messages/errors)#21nickolay wants to merge 6 commits inton1k0:masterfrom
nickolay wants to merge 6 commits inton1k0:masterfrom
Conversation
…to PhantomJS and display its stderr.
- Displays a better error when communicating with the readable-proxy server (e.g. when it is not started) - Only loads the original page in an iframe after we know readability ran successfully
…js) to appear in the web UI with proper object formatting.
Until this change the console logs were ignored in server.js (when returning an error), and in case there was no `result.content` in phantom-scrape.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding #12, the new version of PhantomJS was no better in than the old one when it failed :)
After playing around yesterday I have a number of patches that improve diagnostics making it easier to debug problems. Not sure which of them are acceptable (e.g. is
--debugoutput safe to include in the http://readable-proxy.herokuapp.com/ and what is the browser support of the Web UI - is the Fetch API fine to use?).This conflicts with 62ca359 , but I don't understand the reason behind that change.