Open
Conversation
…ent module and fixed behavior/cleancode issues across all code
yardenc2003
reviewed
Jun 8, 2024
math_functions.py
Outdated
Comment on lines
+3
to
+6
| def calculate_triangular_number(num: int) -> int: | ||
| if num <= 0: | ||
| return 0 | ||
| return sum(range(num + 1)) |
There was a problem hiding this comment.
Although the name sounds great, it's not very accurate as not all positive integers belong to the triangular numbers sequence (1, 3, 6, 10, 15...).
I more suitable name would be calculate_sum_up_to or something like that.
math_functions.py
Outdated
Comment on lines
+35
to
+40
| def print_numbers(num: int) -> None: | ||
| for i in range(num): | ||
| if is_prime(i): | ||
| print(f"{i} is prime") | ||
| else: | ||
| print(f"{i} is not prime") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.