unfreeze LLM layers using param --unfreeze_text_layers in the pretrai…#11
Open
Satyajitv wants to merge 2 commits intonahidalam:maya_pretrainfrom
Open
unfreeze LLM layers using param --unfreeze_text_layers in the pretrai…#11Satyajitv wants to merge 2 commits intonahidalam:maya_pretrainfrom
Satyajitv wants to merge 2 commits intonahidalam:maya_pretrainfrom
Conversation
nahidalam
reviewed
Jan 26, 2025
| unfreeze_vision_layers: Optional[int] = field(default=None) | ||
|
|
||
|
|
||
| def __post_init__(self): |
Owner
There was a problem hiding this comment.
@Satyajitv what is the purpose of the _post_init function?
nahidalam
reviewed
Jan 26, 2025
|
|
||
| def __post_init__(self): | ||
| if self.unfreeze_text_layers or self.unfreeze_vision_layers: | ||
| self.freeze_backbone = False |
Owner
There was a problem hiding this comment.
looks like freeze_backbone is not really for training haotian-liu#723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capability to unfreeze layer in LLM using --unfreeze_text_layers param.
Based on the number (x) we pass, code will freeze last x layers in the LLM used.