Draft
Conversation
17ceb15 to
fda1acc
Compare
fda1acc to
88a983d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior work
Currently, OBI can be set to one of three output modes: Sixteen bit, Eight bit, or None.
It would be useful to instead be able to enable or disable output on a per-pixel basis.
Proposed Change
Currently there are 4 bits of Free Real Estate in the header of every pixel command. One of those could be used to enable or disable whether data is returned for that pixel.
Benefits
This change does not solve #43, but provides another tool for handling flyback distortion. For example, one could use VectorPixel with output disabled to define the beam flyback path between subsequent raster frames, or implement a "front/back porch" by disabling output for some RasterPixels within a raster frame.
Drawbacks
This change would be somewhat incompatible with my vision for ArrayCommand, but ArrayCommand hasn't been used to build anything yet anyway.I've changed the implementation of ArrayCommand to be compatible with pixel commands that have extra metadata.
Examples
Previous
Raster Pixel:
Array of Raster Pixels:
New
Raster Pixel:
Array of Raster Pixels