Merged
Conversation
Contributor
Author
|
The test failures seem to be due to |
e904653 to
d13daab
Compare
Contributor
Author
|
Here is a summary of what I am doing:
|
Contributor
Author
Old Run times (approx)ubuntu-latest, oldestdeps - 35 min New run times (approx)ubuntu-latest, oldestdeps - 15 min These times are for the github runners. They run a lot faster on my laptop. |
Contributor
|
This is good. I remember we had tried this a while ago but for some reason didn't implement it in CI. But I don't see any reason not to. Even a factor of ~2 change helps. Is this ready to merge? |
Contributor
Author
|
Yes |
This was referenced Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github runners now provide multiple cores.
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
Our tests can be sped up significantly if we run them in parallel.