Show logs in the correct Jupyter notebook cell#1952
Show logs in the correct Jupyter notebook cell#1952rossjjennings wants to merge 1 commit intonanograv:masterfrom
Conversation
|
The test failure here is happening for MacOS only, so I can't easily reproduce it. The problem seems to be a bunch of cases of Edit: On second thought, it might be that this is related to the changes here, because |
|
How about just make this an option to |
Fixes #1951. The problem where logging messages were shown in the incorrect cell (the cell where
pint.logging.setup()was called) seems to have been caused by passing theenqueue=Trueoption to Loguru'slogger.add()function. This PR simply removes the option. I've confirmed that this works both in a newer environment that showed the issue, and in an older one, which didn't have this issue, even withenqueue=True.I'm not sure why we were using
enqueue=Trueto begin with. The docstring forlogger.add()says this about it:Hopefully getting rid of this option (and switching back to
enqueue=False, which is the default in Loguru) will not cause issues in some use case I'm not aware of involving multiple PINT processes trying to log to a single file. But I think most likely this option was originally added in an attempt to get logging in a Jupyter notebook to work better, which is now backfiring.