Skip to content

Changed integer type long to long long for Windows compatibility#121

Open
jjohnpeter wants to merge 1 commit intonanograv:mainfrom
jjohnpeter:fix-longlong-cyutils
Open

Changed integer type long to long long for Windows compatibility#121
jjohnpeter wants to merge 1 commit intonanograv:mainfrom
jjohnpeter:fix-longlong-cyutils

Conversation

@jjohnpeter
Copy link

For Windows Compatibility:
long --> longlong
1e10-->10000000000

@kayhangultekin kayhangultekin self-assigned this Nov 7, 2025
@kayhangultekin kayhangultekin added the bug Something isn't working label Nov 7, 2025
@kayhangultekin
Copy link
Collaborator

I can confirm that this works on a Mac with python 3.13 and cython 3.2.0. I cannot confirm that it works on Windows, though. I have no reason doubt @jjohnpeter that it works, but it seems out of principle we should get one other person to test it on Windows.

@pturgeon01
Copy link

Hello,

I just installed this branch on my windows PC (Microsoft Windows 11 Pro, version 10.0.26100 Build 26100), using python version 3.11.14 and cython version 0.29.37 I managed to get it working by fixing a few supplementary issues I list below.

The first issue I ran into was an encoding incompatibility within setup.py when running step (3) in your README:

   with open(join('.', "README.md"), "r") as handle:

I fixed this by changing line 20 in setup.py to:

   with open(join('.', "README.md"), "r", encoding="utf8") as handle:

There are also lines 47 and 65 in setup.py that should be commented out:

    extra_compile_args=['-Wno-unreachable-code-fallthrough', '-Wno-unused-function'],

due to it only being relevant mac/linux installations and causing issues with installing the requirements in windows.

Once these issues were resolved, I also needed to install "Visual Studio Installer, Desktop development with C++" to complete step (4), which is mentioned in the terminal after unsuccessfully running step 4 but I think should also be mentioned on the README.

Finally, after manually installing jupyter lab in the conda environment I managed to get the tutorial notebooks working (aside from some python version incompatibilities, which are due to me using the 3.11 installation instead of 3.9 and are unrelated to the windows installation). This means that the cyutils fixes work. On my work computer I regularly use holodeck's SAM features with these fixes implemented and have currently not run into any issues.

I hope this feedback helps.

@kayhangultekin
Copy link
Collaborator

Thanks, @pturgeon01! A lot of this seems to be related to general Windows operability (See #84), which is, unfortunately, not a high priority at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants