Skip to content

sample_app: improve error handling and event reporting in ProcessCmd #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajv79 wants to merge 2 commits into
base: main
Choose a base branch
from
+43 −21
Open

sample_app: improve error handling and event reporting in ProcessCmd #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65caabf
sample_app: improve error handling and event reporting in ProcessCmd
rajv79 Feb 5, 2026
005cdea
sample_app: initialize TblPtr and fix release error message
rajv79 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 43 additions & 21 deletions fsw/src/sample_app_cmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,39 +112,61 @@ CFE_Status_t SAMPLE_APP_ResetCountersCmd(const SAMPLE_APP_ResetCountersCmd_t *Ms
CFE_Status_t SAMPLE_APP_ProcessCmd(const SAMPLE_APP_ProcessCmd_t *Msg)
{
CFE_Status_t Status;
void * TblAddr;
SAMPLE_APP_ExampleTable_t *TblPtr;
void * TblAddr = NULL;
SAMPLE_APP_ExampleTable_t *TblPtr = NULL;
const char * TableName = "SAMPLE_APP.ExampleTable";

/* Sample Use of Example Table */
/* Count command execution */
SAMPLE_APP_Data.CmdCounter++;

/* Get table address */
Status = CFE_TBL_GetAddress(&TblAddr, SAMPLE_APP_Data.TblHandles[0]);
if (Status < CFE_SUCCESS)
{
CFE_ES_WriteToSysLog("Sample App: Fail to get table address: 0x%08lx", (unsigned long)Status);
SAMPLE_APP_Data.ErrCounter++;

CFE_EVS_SendEvent(SAMPLE_APP_CMD_ERR_EID,
CFE_EVS_EventType_ERROR,
"SAMPLE_APP_ProcessCmd: Failed to get table address, RC=0x%08lx",
(unsigned long)Status);

CFE_ES_WriteToSysLog("Sample App: Fail to get table address: 0x%08lx",
(unsigned long)Status);

return Status;
}
else

/* Use the table */
TblPtr = (SAMPLE_APP_ExampleTable_t *)TblAddr;
CFE_ES_WriteToSysLog("Sample App: Example Table Value 1: %d Value 2: %d",
TblPtr->Int1, TblPtr->Int2);

SAMPLE_APP_GetCrc(TableName);

/* Release table address */
Status = CFE_TBL_ReleaseAddress(SAMPLE_APP_Data.TblHandles[0]);
if (Status != CFE_SUCCESS)
{
TblPtr = TblAddr;
CFE_ES_WriteToSysLog("Sample App: Example Table Value 1: %d Value 2: %d", TblPtr->Int1, TblPtr->Int2);

SAMPLE_APP_GetCrc(TableName);

Status = CFE_TBL_ReleaseAddress(SAMPLE_APP_Data.TblHandles[0]);
if (Status != CFE_SUCCESS)
{
CFE_ES_WriteToSysLog("Sample App: Fail to release table address: 0x%08lx", (unsigned long)Status);
}
else
{
/* Invoke a function provided by SAMPLE_APP_LIB */
SAMPLE_LIB_Function();
}
SAMPLE_APP_Data.ErrCounter++;

CFE_EVS_SendEvent(SAMPLE_APP_CMD_ERR_EID,
CFE_EVS_EventType_ERROR,
"SAMPLE_APP_ProcessCmd: Failed to release table address, RC=0x%08lx",
(unsigned long)Status);

CFE_ES_WriteToSysLog("Sample App: Fail to release table address: 0x%08lx",
(unsigned long)Status);

return Status;
}

return Status;
/* Invoke a function provided by SAMPLE_APP_LIB */
SAMPLE_LIB_Function();

return CFE_SUCCESS;
}


/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/
/* */
/* A simple example command that displays a passed-in value */
Expand Down