Improve dsktool portability and fix some issues#4
Open
Robert-van-Engelen wants to merge 3 commits intonataliapc:masterfrom
Open
Improve dsktool portability and fix some issues#4Robert-van-Engelen wants to merge 3 commits intonataliapc:masterfrom
Robert-van-Engelen wants to merge 3 commits intonataliapc:masterfrom
Conversation
malloc.h is deprecated, malloc/free are declared in stdlib.h
nothing is specifically C++ in dsktool.c comment out STATIC because this prevents linking on some systems like MacOS
reason: char may or may not be signed, no assumption should be made fix: change char comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves dsktool portability and fixes some issues:
I've tested dsktool on Linux and MacOS using a 720K MSX .dsk image created with WebMSX for my ForthMSX project.
I've not tested on Windows. However, I do not expect problems, because these source code changes are minimal and follow the C/C++ standard.