Added possibility to limit the amount of data retrieved#148
Open
daigo75 wants to merge 6 commits intonategood:masterfrom
Open
Added possibility to limit the amount of data retrieved#148daigo75 wants to merge 6 commits intonategood:masterfrom
daigo75 wants to merge 6 commits intonategood:masterfrom
Conversation
Author
|
Note: the coding style used for the library is different from the one I normally use, therefore you might need to make a couple of adjustments. |
* Pevious logic was not taking into account the case in which the limit was high enough for the Request to retrieve the whole page. When this is the case, the $result variable contains "true" (boolean), and the actual content must be retrieved from Request::retrieved_data property.
Owner
|
Hi @daigo75. Please convert the spacing in here to spaces as opposed to hard tabs for consistency. Thanks! |
Author
|
I forgot, my editor is set to tabs (never liked spaces much, too rigid). I will review the files and make the conversion. By the way, technically, spaces are hard indentation, while tabs are a soft one (two spaces are always two spaces, while tabs can be displayed as 1, 2, 3 or more). :) |
Author
|
Done! Tabs are now spaces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. feature request #137.
Usage example