Allow Request to be extended by changing class name 'Request' to static#264
Open
bluehaoran wants to merge 11 commits intonategood:masterfrom
Open
Allow Request to be extended by changing class name 'Request' to static#264bluehaoran wants to merge 11 commits intonategood:masterfrom
bluehaoran wants to merge 11 commits intonategood:masterfrom
Conversation
Author
|
CI fails :/
|
Owner
|
I don't believe we've tried testing either. Will add 7 to CI in a different PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #231 because that became a bit of a tangled mess.
This is cleaner and changes just one file, and doesn't fail CI.