Fix issue #299: calling expectsJson() before body() breaks response parsing#312
Open
elliota43 wants to merge 1 commit intonategood:masterfrom
Open
Fix issue #299: calling expectsJson() before body() breaks response parsing#312elliota43 wants to merge 1 commit intonategood:masterfrom
elliota43 wants to merge 1 commit intonategood:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
expectsJson()is called beforebody()with a different mime type, theexpected_typegets overwritten, causing incorrect response parsing.Example:
This would incorrectly parse the JSON response as form data, resulting in:
Array (size=1) '{"exampleResponseFromServer": "data processed successfully"}' => string '' (length=e request body's content type and doesn't overwrite the expected response type.Solution
Changed
body()method to usecontentType()instead ofmime(), so it only sets the request body's content type and doesn't overwrite the expected response type.This change:
expected_typewhen set beforebody()content_typefor the request bodyTesting
Added test cases to verify:
expectsJson()beforebody()preserves expected_typebody()only sets content_type, not expected_typeAll 46 tests pass (44 existing + 2 new).
Fixes #299