This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Remove module tag. Now interpreted as CommonJS#9
Open
schloerke wants to merge 3 commits intonativew:mainfrom
Open
Remove module tag. Now interpreted as CommonJS#9schloerke wants to merge 3 commits intonativew:mainfrom
schloerke wants to merge 3 commits intonativew:mainfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
setup()is(void | Promise<void>)(https://github.com/evanw/esbuild/blob/223150f924d746226eedd703d7419dfa636c642f/lib/shared/types.ts#L189). When there are no babel options to parse, it now returns nothing.Changes:
require()/modules.exportto import objects and export the default value"type": "module"frompackage.jsonto default back to"type": "commonjs"External Support:
Since the plugin is small and only has a
defaultexport, then we can convert it to a CJS module. Now both CJS and ES modules can require/import this module.(Motivation by not being able to import ES modules within
ts-node.)