WIP: clustering, drop partner neurons with type=NA#28
Draft
WIP: clustering, drop partner neurons with type=NA#28
Conversation
Contributor
jefferis
commented
Oct 30, 2024
- leaving NA types presumably adds some noise; it could be argued that this is a good thing if it leads to lumping cells when a lot of partner neurons cannot be identified
- I anticipate that merging this will change a lot of across dataset clustering slightly
- need to check impact on single dataset clustering (grouped vs ungrouped)
- there should be a pathway to revert to previous behaviour – should think about whether this should be via an option (already an implemented), an explicit function argument or both
* this will change a lot of across dataset clustering slightly * need to check impact on single dataset clustering (grouped vs ungrouped)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.