-
Notifications
You must be signed in to change notification settings - Fork 1
99 - Update link preview images #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ndit-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ndit-old-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@royemosby Testing it on LinkedIn with https://deploy-preview-100--ndit-old-staging.netlify.app/ isn’t working, so maybe something is off, or maybe it’s just that branch staging URL. Unsure. Edit: Oh, I know what it is. The images are sourced from nd-in-tech.org, and since the images are NOT on production yet, they're not there to be sourced! |
|
@royemosby Sorry to bother, but any super huge objections or things that look absolutely wild with this vs what's on main? I'd love to share the site online but need it to have a working link preview. :) It didn't break staging when I put it on there or anything, but we can't test if the new part (the link preview) works until it's on production unfortunately. |
galactic-src
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me! If you want to be able to test it, you can always add the logo in a separate PR first.
|
Hi @hayleyw7 - just seeing this - I can give things a look this weekend. |
Update link preview images
Description
We had an old image for link preview that was deleted and no longer showed up.
Issue Board Ticket
Type of change
Change log
Testing
Checklist