Skip to content

Conversation

@hayleyw7
Copy link
Member

@hayleyw7 hayleyw7 commented Dec 9, 2024

Update link preview images

Description

We had an old image for link preview that was deleted and no longer showed up.

Issue Board Ticket

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Infrastucture
  • Other (please clarify): _

Change log

  • Added new banner image to match social banners
  • Added more meta tag info so we have "everything" there

Testing

  • It will have to be tested live on staging.

Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new console warnings.
  • I manually tested to prove my fix is effective or that my feature works.
  • I have assigned this PR to an owner.

@hayleyw7 hayleyw7 added the bug Something isn't working label Dec 9, 2024
@hayleyw7 hayleyw7 self-assigned this Dec 9, 2024
@netlify
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for ndit-staging ready!

Name Link
🔨 Latest commit 0997e15
🔍 Latest deploy log https://app.netlify.com/sites/ndit-staging/deploys/67577bec2a2759000845ae7e
😎 Deploy Preview https://deploy-preview-100--ndit-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for ndit-old-staging ready!

Name Link
🔨 Latest commit 0997e15
🔍 Latest deploy log https://app.netlify.com/sites/ndit-old-staging/deploys/67577bec719daa0008a86b4b
😎 Deploy Preview https://deploy-preview-100--ndit-old-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hayleyw7
Copy link
Member Author

hayleyw7 commented Dec 9, 2024

@royemosby Testing it on LinkedIn with https://deploy-preview-100--ndit-old-staging.netlify.app/ isn’t working, so maybe something is off, or maybe it’s just that branch staging URL. Unsure.

Edit: Oh, I know what it is. The images are sourced from nd-in-tech.org, and since the images are NOT on production yet, they're not there to be sourced!

@hayleyw7 hayleyw7 changed the base branch from main to staging December 20, 2024 22:08
@hayleyw7 hayleyw7 changed the base branch from staging to main December 20, 2024 22:11
@hayleyw7
Copy link
Member Author

@royemosby Sorry to bother, but any super huge objections or things that look absolutely wild with this vs what's on main? I'd love to share the site online but need it to have a working link preview. :) It didn't break staging when I put it on there or anything, but we can't test if the new part (the link preview) works until it's on production unfortunately.

Copy link
Collaborator

@galactic-src galactic-src left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! If you want to be able to test it, you can always add the logo in a separate PR first.

@royemosby
Copy link
Contributor

Hi @hayleyw7 - just seeing this - I can give things a look this weekend.

@hayleyw7 hayleyw7 merged commit 7cb2e0e into main Jan 1, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants