Skip to content

Conversation

@hayleyw7
Copy link
Member

@hayleyw7 hayleyw7 commented Jan 1, 2025

Make calendar show ND In Tech one only

Description

Right now, the calendar on the site combines the ND In Tech calendar with the user's personal calendar. This removed code that shows the user's calendar.

Issue Board Ticket

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Infrastucture
  • Other (please clarify): _

Change log

  • Remove &<personal-cal-code from calendar embed URL.

Testing

  • Tested locally in localhost:8080

Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new console warnings.
  • I manually tested to prove my fix is effective or that my feature works.
  • I have assigned this PR to an owner.

@hayleyw7 hayleyw7 added the bug Something isn't working label Jan 1, 2025
@hayleyw7 hayleyw7 self-assigned this Jan 1, 2025
@netlify
Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for ndit-old-staging ready!

Name Link
🔨 Latest commit 9a1227c
🔍 Latest deploy log https://app.netlify.com/sites/ndit-old-staging/deploys/677a4087932f710008027d28
😎 Deploy Preview https://deploy-preview-102--ndit-old-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for ndit-staging ready!

Name Link
🔨 Latest commit 9a1227c
🔍 Latest deploy log https://app.netlify.com/sites/ndit-staging/deploys/677a408702a5200008859d75
😎 Deploy Preview https://deploy-preview-102--ndit-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@galactic-src
Copy link
Collaborator

It looks like the prettier fail is because we're using a quite old version of node - I can replicate if I use node 14.17.6 locally, as we do in the pipeline.

Any reason we want such an old version? Node 22 is current and will be maintained a while yet (https://nodejs.org/en/about/previous-releases).

Copy link
Contributor

@royemosby royemosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! 👉⏺️ ~~~~~~ 🚀

@royemosby
Copy link
Contributor

It looks like the prettier fail is because we're using a quite old version of node - I can replicate if I use node 14.17.6 locally, as we do in the pipeline.

Any reason we want such an old version? Node 22 is current and will be maintained a while yet (https://nodejs.org/en/about/previous-releases).

None that I'm aware of. We want to update that here or pull it out into another ticket?

@galactic-src galactic-src mentioned this pull request Jan 4, 2025
10 tasks
@galactic-src
Copy link
Collaborator

It looks like the prettier fail is because we're using a quite old version of node - I can replicate if I use node 14.17.6 locally, as we do in the pipeline.
Any reason we want such an old version? Node 22 is current and will be maintained a while yet (https://nodejs.org/en/about/previous-releases).

None that I'm aware of. We want to update that here or pull it out into another ticket?

Made a PR here #103

@hayleyw7 hayleyw7 merged commit ac4ada8 into main Jan 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants