Skip to content

Conversation

@galactic-src
Copy link
Collaborator

Add page - "Resources"

Description

Add Resources page to the nav and show list of resources links as per the issue

[link to ticket on issue board]

Type of change

New feature

Change log

  • Added Resources item to navbar
  • Added Resources.html to show categorised lists of links

Is this the best place in the nav bar for this item?

Do we want the links displayed as list items?

We could do something cuter/slicker for the member-made things. Little chips with a coloured background? Could be a class which applies a ::after for example, or in a `.
Maybe simplest is best for accessibility for now though.

Testing

Opened the page, tried each link.
Tried navigating to and from the page, via the nav.

Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new console warnings.
  • [XI manually tested to prove my fix is effective or that my feature works.
  • I have assigned this PR to an owner.

@galactic-src
Copy link
Collaborator Author

For accessibility we could consider some styling to pick out links - at the moment they look a lot like text in dark mode. (Ideally not reliant solely on colour)

We could also consider a :hover: style to hint that they can be interacted with.

@galactic-src galactic-src changed the title Resources page Feature/Resources page Nov 15, 2024
@hayleyw7
Copy link
Member

On hold until this one is merged into main: #67.

@hayleyw7 hayleyw7 assigned hayleyw7 and galactic-src and unassigned hayleyw7 Nov 15, 2024
@hayleyw7 hayleyw7 self-requested a review November 15, 2024 23:06
Copy link
Member

@hayleyw7 hayleyw7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged main into this branch so it's up-to-date with the big changes. I think it's a great start, but we may want to chat more about how exactly we want it to look and function, as well as whether or not we want it available on first launch (or add it later). Let's hold and chat?

@galactic-src
Copy link
Collaborator Author

Yeah totally! This was in the spirit of the other pages 😂

Maybe this wasn't quite ready for picking up, but v sensible to have an issue for it, to act as a backlog 👍
We could stick a label on issues that are blocked, and mention what is needed in the description?

Shall we close the PR for now?

@hayleyw7 hayleyw7 changed the title Feature/Resources page Feature/Resources page (WIP) Nov 18, 2024
@galactic-src
Copy link
Collaborator Author

Definitely needs a better colour for dark mode link text 😱
But I know you had potentially bigger changes/designs to consider so won't worry about it right now.

@netlify
Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for ndit-staging ready!

Name Link
🔨 Latest commit b5eeae8
🔍 Latest deploy log https://app.netlify.com/sites/ndit-staging/deploys/67439bf12d272000084a3798
😎 Deploy Preview https://deploy-preview-77--ndit-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants