-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/Resources page (WIP) #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
For accessibility we could consider some styling to pick out links - at the moment they look a lot like text in dark mode. (Ideally not reliant solely on colour) We could also consider a |
|
On hold until this one is merged into main: #67. |
hayleyw7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged main into this branch so it's up-to-date with the big changes. I think it's a great start, but we may want to chat more about how exactly we want it to look and function, as well as whether or not we want it available on first launch (or add it later). Let's hold and chat?
|
Yeah totally! This was in the spirit of the other pages 😂 Maybe this wasn't quite ready for picking up, but v sensible to have an issue for it, to act as a backlog 👍 Shall we close the PR for now? |
|
Definitely needs a better colour for dark mode link text 😱 |
✅ Deploy Preview for ndit-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Add page - "Resources"
Description
Add Resources page to the nav and show list of resources links as per the issue
[link to ticket on issue board]
Type of change
New feature
Change log
Is this the best place in the nav bar for this item?
Do we want the links displayed as list items?
We could do something cuter/slicker for the member-made things. Little chips with a coloured background? Could be a class which applies a
::afterfor example, or in a `.Maybe simplest is best for accessibility for now though.
Testing
Opened the page, tried each link.
Tried navigating to and from the page, via the nav.
Checklist