Skip to content

Conversation

@hayleyw7
Copy link
Member

@hayleyw7 hayleyw7 commented Dec 2, 2024

Loading Icon Ideas

Description

Calendar sometimes loaded an error at first, so I tossed this on all iframes, thinking it could also make the UE more smooth with slow internet connections too. However, this is a pretttttttttty long delay. Ideally, we find a better solution to that popup and can use a loading icon like this for the normal loading pause.

THIS DOESN'T EVEN INCLUDE A DARK MODE OPTION AT THIS TIME. Since it's a draft musing, it's only in day mode unless we decide to implement it somewhere in one way or another.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Infrastucture
  • Other (please clarify): _

Change log

  • Added loading icon for iframes
  • Styled loading icon
  • On load, hid iframes and showed loading icon
  • After a 2000 delay, showed iframes and hid loading icon

Testing

  • Refreshed both iframe pages (contact and events) logged in on Chrome and in incognito mode

Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new console warnings.
  • I manually tested to prove my fix is effective or that my feature works.
  • I have assigned this PR to an owner.

@hayleyw7 hayleyw7 added the bug Something isn't working label Dec 2, 2024
@hayleyw7 hayleyw7 self-assigned this Dec 2, 2024
@netlify
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for ndit-staging ready!

Name Link
🔨 Latest commit 036eaa0
🔍 Latest deploy log https://app.netlify.com/sites/ndit-staging/deploys/674dfeb387cc4c000871ac46
😎 Deploy Preview https://deploy-preview-96--ndit-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants