Fixed a problem with selected title color for segment#25
Closed
petergam wants to merge 7 commits intonealyoung:masterfrom
petergam:master
Closed
Fixed a problem with selected title color for segment#25petergam wants to merge 7 commits intonealyoung:masterfrom petergam:master
petergam wants to merge 7 commits intonealyoung:masterfrom
petergam:master
Conversation
|
+1 This PR fixes the bug. |
|
well done |
added 4 commits
September 29, 2015 11:34
This is done to avoid a visual glitch when the selected title color is in a lighter color than the normal text color. Further this commit adds support for a more smooth transition to a bold selected font
This reverts commit cda41c6.
added 2 commits
September 30, 2015 09:10
This reverts commit 3fcee3f.
This is done to avoid a visual glitch when the selected title color is in a lighter color than the normal text color. Further this commit adds support for a more smooth transition to a bold selected font
Contributor
Author
|
This PR was never merged. The changes in this PR is included in my new PR #35. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A problem has added where the
textColorof theNYSegmentLabelwhere changed, which caused a behaviour where the segment would keep to appear selected when moving the indicator. ThetextColorof theNYSegmentLabelshould not be changed when selected since it is handled by themaskFrameinstead.