This repository was archived by the owner on Sep 19, 2019. It is now read-only.
Conversation
it makes no sense anymore since shipwire is on shipment now. Also it was not tested and not working anymore
It does not seem to really do something and it's not tested
It's not used anymore and it's actually doing nothing but a call to the api that would list the stock for that SKU: https://github.com/nebulab/shipwire/blob/a548d9733ba67906f3a4e1e6f18119da843c94e1/lib/shipwire/stock.rb#L3-L5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SimpleCov to check the coverage of the project. It also performs some steps to improve it.
Main things done are:
Spree::Admin::OrdersController#shipwiremethod: it was not working and out of date, since now shipwire is connected viaSpree::ShipmentmodelSpree::ReturnAuthorizationsControllerthat was not tested and probably uselessSpree::VariantNOTE
Coverage is still quite low on
app/models/shipwiresince there are a lot of things untested since we are waiting for billr578/shipwire#6 to be merged (this won't happen, even because that PR is untested itself).Ci is failing only on Solidus 2.3 and 2.4 due to a factory_girl issue that will be handled on Solidus