Support LaunchImage and Blurr together in IOS#38
Open
eddyuan wants to merge 15 commits intoneckaros:masterfrom
Open
Support LaunchImage and Blurr together in IOS#38eddyuan wants to merge 15 commits intoneckaros:masterfrom
eddyuan wants to merge 15 commits intoneckaros:masterfrom
Conversation
# Conflicts: # ios/Classes/SwiftSecureApplicationPlugin.swift
neckaros
requested changes
Jul 21, 2022
Owner
neckaros
left a comment
neckaros
left a comment
There was a problem hiding this comment.
Thank you for this merge request! Please just update the readme as commented.
I don't have a Mac to test but the code seems good and I will trust your tests.
| @@ -1,16 +1,22 @@ | |||
| **previously nammed secure_window** | |||
|
|
|||
| Forked from [neckaros](https://github.com/neckaros/secure_application) & [stevenspiel](https://github.com/stevenspiel/secure_application) | |||
Owner
There was a problem hiding this comment.
Since it would no longer be a fork could you remove this part and merge the extended features please?
| ### Use useLaunchImageIOS | ||
| Open your_project/ios in xcode, add LaunchImage if not already exist | ||
|
|
||
| <img src="https://github.com/eddyuan/secure_application/blob/master/example/screenshot/xcode_setting.png?raw=true"/> |
Owner
There was a problem hiding this comment.
CAN you use the link for target repo please?
|
Hi @eddyuan any updates for this PR? Is it read to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged from stevenspiel and made some changes to make both LaunchImage and Blur work together (Image on top of Blur)