Skip to content

make regex more lenient #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thesuhas merged 3 commits into from
Feb 12, 2026
Merged

make regex more lenient #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da2c895
make regex more lenient
thesuhas Feb 12, 2026
5b3a6fe
fmt and test fix
thesuhas Feb 12, 2026
41086f8
update test
thesuhas Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion release-pr/src/neon_release_pr/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,10 @@ def github_repo(origin_url: str | None) -> str | None:
if origin_url is None:
return None

match = re.search(r"github.com[:\d/]+?(?P<repo>[^/]+?/[^/]+?)(\.git)?$", origin_url)
match = re.search(
r"github[^:/\s]*\.com[^:/\s]*(?::\d+)?[:\/](?P<repo>[^/]+?/[^/]+?)(\.git)?$",
origin_url,
)

assert match, (
"There should be exactly one repo owner/name match in the url for remote origin"
Expand Down
27 changes: 20 additions & 7 deletions release-pr/tests/test_origin_url_regex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,23 @@


def test_round_trip_parse_then_generate():
for url in [
"https://github.com/databricks-eng/hadron.git",
"git@github.com:neondatabase/neon.git",
"ssh://git@github.com:22/neondatabase/neon.git",
"https://github.com/databricks-eng/hadron",
]:
assert git.github_repo(url) is not None, f"No match for url {url}"
test_cases = [
("https://github.com/databricks-eng/hadron.git", "databricks-eng/hadron"),
("git@github.com:neondatabase/neon.git", "neondatabase/neon"),
("ssh://git@github.com:22/neondatabase/neon.git", "neondatabase/neon"),
("https://github.com/databricks-eng/hadron", "databricks-eng/hadron"),
(
"git@github-neon.com:neondatabase/dev-actions.git",
"neondatabase/dev-actions",
),
("git@github.com-emu:databricks-eng/hadron.git", "databricks-eng/hadron"),
(
"ssh://git@github-neon.com:22/neondatabase/dev-actions.git",
"neondatabase/dev-actions",
),
("git@github.com-emu:databricks-eng/hadron.git", "databricks-eng/hadron"),
]
for url, expected_repo in test_cases:
assert git.github_repo(url) == expected_repo, (
f"Expected {expected_repo} for url {url}"
)