Merged
Conversation
feat: add openteletry metrics support for each backend
…refixes fix: device-discovery remove scope site from prefix
…rtificate feat: add skip tls to git config manager
fix: apply skipTLS to every git remote call
chore: bump go version to 1.24.2
chore: fix docs samples run command
…dules group across 1 directory (#95) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feat: initial snmp support
…the go_modules group across 1 directory (#125) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
feat: improve snmp discovery docs
feat: bundle the lookup extensions in orb-agent image
|
Go test coverage
Total coverage: 57.5% |
leoparente
approved these changes
Jun 20, 2025
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to improve backend functionality, streamline workflows, and enhance OpenTelemetry (OTLP) integration. Key changes include the addition of support for the SNMP discovery backend, updates to Go versions and dependencies, and refinements to OTLP endpoint configurations across multiple backends.
Backend Enhancements:
snmp_discoverybackend in theREADME.mdand updated related documentation links. (README.md: [1] [2]deviceDiscoveryBackendandnetworkDiscoveryBackend, enabling dynamic setup based on thecommon.Otel.Grpcvalue. (agent/backend/devicediscovery/device_discovery.go: [1] [2] [3];agent/backend/networkdiscovery/network_discovery.go: [4] [5] [6]pktvisorBackend, parsing host and port from a unified HTTP URL. (agent/backend/pktvisor/pktvisor.go: agent/backend/pktvisor/pktvisor.goL305-R316)Workflow and Configuration Updates:
1.24across all workflows (develop.yaml,lint.yaml,release.yaml,tests.yaml) for compatibility and performance improvements. (develop.yaml: [1];lint.yaml: [2];release.yaml: [3];tests.yaml: [4]golangci-lint-actionto versionv8.0.0and adjusted linting configurations in.github/golangci.yamlfor better code quality checks. (lint.yaml: [1];.github/golangci.yaml: [2]Codebase Simplification:
Cmd.StdoutandCmd.Stderrreferences inCmdWrapper, replacing them with direct access toStdoutandStderr. (agent/backend/cmd.go: agent/backend/cmd.goL84-R89)depstarget inMakefileto ensure dependencies are tidied during builds. (Makefile: MakefileR40-R42)Test Improvements:
if-elseblocks withswitchstatements in backend tests for cleaner handling of HTTP methods. (agent/backend/devicediscovery/device_discovery_test.go: [1] [2];agent/backend/networkdiscovery/network_discovery_test.go: [3] [4];agent/backend/pktvisor/pktvisor_test.go: [5] [6];agent/backend/otel/otel_test.go: [7] [8]